[PROGRAM] OpenYS - Open Source YSFlight Server!

Flake · Post by **Flake** » Mon Apr 13, 2015 5:28 am

I'll investigate.

Flake · Post by **Flake** » Wed Apr 15, 2015 5:33 am

Fixed that problem now.

Also fixed a vulnarability in the String.ReplaceAll extension method - if the newstring contained the old string( eg: "ABC" contains "AB") it would infinitely loop... (AB->[ABC]->[ABC]C->[ABC]CC->[ABC]CCC...)

No other issues?

Post by **Neocon** » Wed Apr 15, 2015 5:59 am

Yes. There are other issues. The ground objects show up, but that's all. No runways (rectangle areas for paving and F9 view), no .pc2 map files, no elevation grids. Just the default ground and sky colors and ground objects.

Code: Select all

--- Log Created 2015/04/15 00:44:15 ---
2015/04/15 00:44:15: Welcome to OpenYS Client!

2015/04/15 00:44:15: 

2015/04/15 00:44:15: You are using version: 20150413(1356)[TEST]

2015/04/15 00:44:15: 

2015/04/15 00:44:15: YSFlight Directory is: C:/Program Files (x86)/YSFLIGHT.COM/YSFLIGHT - FIGHT CLUB/

2015/04/15 00:44:15: 

2015/04/15 00:44:15: Loading YSFlight MetaData:

2015/04/15 00:44:23:     Loaded 2283 Aircraft

2015/04/15 00:44:23:     Loaded 34 Scenery

2015/04/15 00:44:23: 

2015/04/15 00:44:23: Loading Scenery: HAWAII

2015/04/15 00:44:23:     Loaded 121 Ground Objects from FLD.

2015/04/15 00:44:23:     Loaded 25 Start Positions from STP.

2015/04/15 00:44:23:     Loaded 0 Ground Objects from YFS.

2015/04/15 00:44:23: 

2015/04/15 00:44:23: Loading Complete!

2015/04/15 00:44:23: 

2015/04/15 00:44:23: Listening for Clients on Port: 7915...

2015/04/15 00:44:23: ======================================

2015/04/15 00:44:23: 

2015/04/15 00:44:23: 

2015/04/15 00:44:36: OpenYS Scheduler set the server name to: YSCAS-Actual.

2015/04/15 00:44:36: *** Current Server Restart Timer Stopped! ***

2015/04/15 00:44:36: OpenYS Scheduler DISABLED the Server Restart Timer.

2015/04/15 00:44:36: OpenYS Scheduler set "Weapons" to ON.

2015/04/15 00:44:36: OpenYS Scheduler set "Missiles" to ON.

2015/04/15 00:44:36: OpenYS Scheduler set Force "Black Out" Setting to OFF.

2015/04/15 00:44:36: OpenYS Scheduler set "Land Everywhere" to ON.

2015/04/15 00:44:36: OpenYS Scheduler set "Collisions" to OFF.

2015/04/15 00:44:36: OpenYS Scheduler set the time to DAY.

2015/04/15 00:44:36: OpenYS Scheduler set the Wind to 12004KTS.

2015/04/15 00:44:36: OpenYS Scheduler set the Visibility to 7500m.

2015/04/15 00:44:36: OpenYS Scheduler revived the ground objects.

2015/04/15 00:44:36: OpenYS Scheduler set automatic weather updates to ON.

2015/04/15 00:48:44: Connecting Client is from a local ip address (127.0.0.1).
Made them a superuser.

2015/04/15 00:48:44: [NCA]Patrick Logging in... 127.0.0.1

2015/04/15 00:48:44: [NCA]Patrick Joined the server.

2015/04/15 00:49:06: [NCA]Patrick Login Complete!

2015/04/15 00:49:14: Server was pinged by a serverlist.

2015/04/15 00:49:15: PHP bot left the server.

2015/04/15 00:49:27: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:27: -Type: 40

2015/04/15 00:49:27: -Data: «                     

2015/04/15 00:49:27: [NCA]Patrick took off (NCA_B737-500)

2015/04/15 00:49:27: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:27: -Type: 40

2015/04/15 00:49:27: -Data: «         @õ        À


2015/04/15 00:49:27: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:27: -Type: 40

2015/04/15 00:49:27: -Data: «         äØ        '

2015/04/15 00:49:28: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:28: -Type: 40

2015/04/15 00:49:28: -Data: «         äØ        ä$

2015/04/15 00:49:28: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:28: -Type: 40

2015/04/15 00:49:28: -Data: «         äØ        |"

2015/04/15 00:49:28: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:28: -Type: 40

2015/04/15 00:49:28: -Data: «         äØ        ú 

2015/04/15 00:49:28: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:28: -Type: 40

2015/04/15 00:49:28: -Data: «         äØ        ì

2015/04/15 00:49:28: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:28: -Type: 40

2015/04/15 00:49:28: -Data: «         äØ        R

2015/04/15 00:49:28: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:28: -Type: 40

2015/04/15 00:49:28: -Data: «         äØ        

2015/04/15 00:49:29: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:29: -Type: 40

2015/04/15 00:49:29: -Data: «         äØ        Þ

2015/04/15 00:49:29: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:29: -Type: 40

2015/04/15 00:49:29: -Data: «         äØ        ¸

2015/04/15 00:49:29: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:29: -Type: 40

2015/04/15 00:49:29: -Data: «         äØ        k

2015/04/15 00:49:29: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:29: -Type: 40

2015/04/15 00:49:29: -Data: «         äØ        

2015/04/15 00:49:29: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:29: -Type: 40

2015/04/15 00:49:29: -Data: «         äØ        D

2015/04/15 00:49:29: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:29: -Type: 40

2015/04/15 00:49:29: -Data: «         äØ        ÷

2015/04/15 00:49:30: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:30: -Type: 40

2015/04/15 00:49:30: -Data: «         äØ        Ñ

2015/04/15 00:49:30: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:30: -Type: 40

2015/04/15 00:49:30: -Data: «         äØ        

2015/04/15 00:49:32: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:32: -Type: 40

2015/04/15 00:49:32: -Data: «         äØ        ]

2015/04/15 00:49:32: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:32: -Type: 40

2015/04/15 00:49:32: -Data: «         äØ        é

2015/04/15 00:49:33: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:33: -Type: 40

2015/04/15 00:49:33: -Data: «         äØ        Ã

2015/04/15 00:49:33: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:33: -Type: 40

2015/04/15 00:49:33: -Data: «         äØ        v

2015/04/15 00:49:33: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:33: -Type: 40

2015/04/15 00:49:33: -Data: «         äØ        

2015/04/15 00:49:36: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:36: -Type: 40

2015/04/15 00:49:36: -Data: «         äØ        Û

2015/04/15 00:49:39: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:39: -Type: 40

2015/04/15 00:49:39: -Data: «         äØ        µ

2015/04/15 00:49:48: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:48: -Type: 40

2015/04/15 00:49:48: -Data: «         µÛ        ä

2015/04/15 00:49:48: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:48: -Type: 40

2015/04/15 00:49:48: -Data: «         ç        ü

2015/04/15 00:49:48: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:48: -Type: 40

2015/04/15 00:49:48: -Data: «         ©ù        ñú

2015/04/15 00:49:48: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:48: -Type: 40

2015/04/15 00:49:48: -Data: «                 
ï

2015/04/15 00:49:48: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:48: -Type: 40

2015/04/15 00:49:48: -Data: «                 ýÜ

2015/04/15 00:49:48: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:48: -Type: 40

2015/04/15 00:49:48: -Data: «         #        äØ

2015/04/15 00:49:48: Unknown Packet From [NCA]Patrick

2015/04/15 00:49:48: -Type: 40

2015/04/15 00:49:48: -Data: «         '        äØ

2015/04/15 00:50:06: [NCA]Patrick left the server.

Flake · Post by **Flake** » Wed Apr 15, 2015 7:31 am

That's an issue with the map data packet - I'm still working that out actually, but it should be sorted by next release! (I've been speaking with Soji...)

You're console log looks normal - Packet 40 not recognised yet...It's the turret position on an aircraft! Those messages won't be in the release version of the program.

Alright. I'll get to work on the map packet tonight.

EDIT - map packet updated to Soji's specifications:

Soji Yamakawa wrote:
Code: Select all
+0   4 bytes FSNETCMD_LOADFIELD(0x04)
+4  32 bytes Field Name
+36  4 bytes x
+40  4 bytes y
+44  4 bytes z
+48  4 bytes h
+52  4 bytes p
+56  4 bytes b
Actually, xyz and hpb are for older versions, but it should be all zero (or I don't know what's going to happen). So, the last 24 bytes need to be zero.

EDIT - fixed Bot left the server message.

Flake · Post by **Flake** » Wed Apr 15, 2015 8:11 am

Yo pat - I've update the map packet but I can't reproduce the map glitch again with the old or new packet system... Assuming you were using hawaii? (The only choice you have at the moment...?) Can you confirm which map you used?

Post by **Neocon** » Wed Apr 15, 2015 3:24 pm

Yes, it is HAWAII.

Flake · Post by **Flake** » Thu Apr 16, 2015 1:28 am

Hm. Well the old structure had a map name of 42 char limit or something like that - it cut short of the required bytes so there could have been a buffer underflow meaning the memory wasn't zero'd out... could be a 1 or a 0 or a 42 in that space... Hopefully this sorts it out yeah?

EDIT - Long strings output into the console will now wrap over lines neatly and will not look messy.
EDIT - All references to "Map" or "MapName" have been changed to "Field" and "FieldName" respectively to better align with the YSFlight Standard.

Flake · Post by **Flake** » Thu Apr 16, 2015 5:07 am

All minor code changes will now be posted on the OpenYSProject twitter - @OpenYSProject!

Flake · Post by **Flake** » Thu Apr 16, 2015 12:43 pm

Last test before next official version - let me know if all good!

Lots of changes - see @OpenYSProject for specifics.

Not sure what I did right in this version but the build size has dramatically shrunk to 950kb, executables and source included.

https://www.mediafire.com/?dpw1s1hkjjw69ug

Post by **Neocon** » Thu Apr 16, 2015 10:36 pm

The issues with the map have been fixed.

New problem, possibly because of the length of the name: Hawaii[PMNV]-EXTENDED and Hawaii[PMNV]-2014 will load in OYS, but I cannot connect to the server. PACIFIC_RIM and TOHOKU_EXT both work.

Also, when you check the command list, you get this:

Flake · Post by **Flake** » Fri Apr 17, 2015 12:22 am

Looks like YSF maps are case sensative. I thought they just had to be capitalised.

I will wind back the map change to make this the case.

Good to see the map problem solved.

Just need to reformat the message outputs is all - I made a bit of a mess...

Post by **Neocon** » Fri Apr 17, 2015 12:59 am

Weather does not change when using the /wind xxxxx command, even though it claims to accept the measurement. I remember reading something about weather, maybe on Twitter. It's still broken. Also, the server restarted while I was eating supper, but when I did a manual restart it didn't run the start-up sequencers.

Also, changing the time of day doesn't work. Fog seems to work.

Post by **Neocon** » Fri Apr 17, 2015 5:09 am

Also, the restart timer is stuck on 120 minutes and can't be changed in the console.

EDIT: Sequencers don't seem to work.

Flake · Post by **Flake** » Fri Apr 17, 2015 10:47 am

Break all the things!

God damnit all to hell.

iqmal_97 · Post by **iqmal_97** » Mon Apr 20, 2015 1:13 pm

Hello? Flake? You here?

Seems he's currently not here, for the time being.

Oh well

*leaves a plate of choc chip cookies and a glass of milk*

Hope you're doing well!

Flake · Post by **Flake** » Sat Apr 25, 2015 1:01 pm

Struggled for hours just to upload this much. Thanks Dodo.

Should be problems solved now - care to confirm?

Post by **Neocon** » Sat Apr 25, 2015 5:52 pm

Only the ground objects are showing up again. Actually, the outline of the map is showing up at some angles, but is standing on its side.

Flake · Post by **Flake** » Sun Apr 26, 2015 4:10 am

Funny. I didn't change anything with the map this time and I also ran into the same problem with Hawaii myself this morning testing.

I think It is a YSF bug tbh. I must have a closer look at the exact order YSF server sends information to clients - that will allow me to emulate it.

I also have fixed another few rare problems this morning - dump will crash should any thread change. Console multiline output fixed now (I wasn't catching newlines to reset the line counter - it supports colors too now so all should be correct length.

I had a rare bug with the day/night cycler but it appears that it's back to normal now too. Day/Night and Time were not setting the /weather time correctly either so I fixed that too.

I also had a memory leak testing this morning and I'll have to find where that is.

Flake · Post by **Flake** » Sun Apr 26, 2015 5:08 am

Well that's interesting...

Post by **Neocon** » Sun Apr 26, 2015 5:51 am

That's what I was talking about when I said it was standing on its side. Weird.

YSFlight Headquarters