Page 1 of 1

[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Sat Jan 24, 2015 11:03 am
by Flake
Added login confirmation for next version.
Console is now dual input/output.

Tomorrow will work on a command handling class and then the first command to dump all server data to a bug file. hopefully that will help me solve the problems.

I'm sorry about the server problems guys - it IS my failsafe protocal to stop the server crashing outright but unfortunately I haven't got an answer as to why it is happening - what's the bet it's something horribly simple.

[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Sun Jan 25, 2015 2:11 am
by Flake
Image

Commands handling and console chat now supported.

Commands so far: /Help, /Listusers.

[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Sun Jan 25, 2015 3:01 am
by Neocon
Thanks. This will be very useful. :)

[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Sun Jan 25, 2015 4:35 am
by Flake
Coded a logger that works in debug mode only - After every line in the program, the program will output what action it has taken. So far it is dropping the entire aircraft lst load process - no data parsing errors yet that I've found. Next will be scenery loading and than grounds.

The program speed is severely neutered in debug mode - frequent log file appends and thread locking reducing the program to snail pace - I've noticed no change yet to the speed of the program in release mode though. Debug mode will be exactly that - you've got a problem and you need to create a bug report log to send me. BTW Bug files are HUGE (Thousands of megabytes.) MY YSF AC Loading dump is already 8mb large per iteration. If anyone has a bug in future you will need to ZIP the log file to compress it!

Turns out I don't need to load the YSFlight Grounds Objects list at all - Don't know why I did that. - should save some time.

Re: [PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Sun Jan 25, 2015 12:24 pm
by Flake
Now Updated to Version 20150125(00)

Changes:
+Console is now threadsafe
+Many other server functions now threadsafe - should be far less data collisions. Praise Helix.
+Ground objects work correctly - turns out I just wasn't rotating them correctly hence why my glide slope was all screwy.
+Console now accepts user input for commands and messages.
+Users can now type commands, see below.
+A few basic commands added. Type /Help with any client or with the console for more details.
+Login confirmation.
+Updated the bug report form - it's now a Google form - much easier to use and better for the environment (and my mental stress). Let me know if you have issues with it.
+Data logger for Debug Build - debug build loads much more slowly now. This is only a partial upgrade - it handles the server loading only, nothing else yet! Hopefully we will iron out the bugs in the loading process!
~Server's becoming more orb by the day... Wasn't really my intention for the project but oh well. I'll accommodate basic requests for this server but user data base, score reporting, user securities etc. aren't intended to be added to the vanilla server!
+Server will now automatically reset after 2 hours. Reset messages will show up from T Minus 30 minutes onwards! It probably doesn't need it but we'll go with it anyway...
+Fixed a few bugs in the loading process for ground and starts. Hopefully this will solve a lot of the problems some of you were having!
+Debug plane spawns in debug build on maps with runways - that's just me testing the flight data packets. Enjoy! :)
-Removed Nukes.

Notes:
~Data logger is only partial - only loading phase at the moment (and that was a LOT of work!)
~Huge upgrade - could be many hidden bugs. Please test thoroughly! Expect an upgrade tomorrow

Download: https://www.mediafire.com/?uyu3jmvs915m1fa

---

Coming soon:
-Read all flight data. (about 75% of the way there! Really! I could smash it out in 3-4 hours if I wanted to!)
-More commands maybe?
-User Private Messaging - why the hell not...



Re: [PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Sun Jan 25, 2015 12:44 pm
by Flake
Now Updated to Version 20150125(01)

Changes:
+Fixed a critical bug where an ampersand (&) typed in the console would kill the program.

Notes:

Download: https://www.mediafire.com/?q8856c6drvw0c2n

---

Coming soon:
-Read all flight data. (about 75% of the way there! Really! I could smash it out in 3-4 hours if I wanted to!)
-More commands maybe?
-User Private Messaging - why the hell not...



[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Sun Jan 25, 2015 7:08 pm
by Neocon
I used the bug report function, but pastebin crashed my browser...twice. Here is a .zip with the log.

In debug mode, the server crashed when I was logging in. The normal OYS does not crash and runs quite well with one exception...
The reason I was running debug mode was because on the Antigua map, the ground objects at Bradshaw Airport were offset from their proper positions in the server. It is only the ground objects in the child scenery for that particular airport. They are placed correctly offline, but using OYS places them, still in the same "formation" about 1 km away from where they should be. I used scenery editor to place those ground objects into a new child scenery and most of them spawn in the right place, so it might have something to do with the particular child scenery in which they were originally located.

[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Mon Jan 26, 2015 12:24 am
by Flake
I'll look into it! Thanks!

EDIT: There doesn't appear to be any errors thrown in the loading process at all, which means my handling logic is wrong. I've downloaded your map and I will install it and test it myself, aiming to find the errors.

It's a problem with my code logic - I'm rotating or repositioning something wrong...

EDIT2: Looks like the Z position is being calculated incorrectly, more info to come.
OPENYS
GROUNDOB PMNVSTAIRS FALSE
IDENTIFY 1
IDANDTAG 76 ""
GNDPOSIT 0m 0m 0m
GNDATTIT 0rad 0rad 0rad
GNDFLAGS 0
NUMGDREC 1 3
2.037
-38452.96 0.0 22696.34 -1.22 0.0 0.0
0 5
0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0 0 0
0 0 0 0 0 0
0
STOCK
GROUNDOB "PMNVSTAIRS"
IDENTIFY 0
GNDPOSIT -38452.96m 0.00m 23988.48m
GNDATTIT -70.00deg 0.00deg -0.00deg
GNDFLAGS 0
EDIT 3: Looks like I've fixed positioning now but the objects don't appear to be rotated correctly? more investigation to come...

EDIT 4: Okay both are now fixed - re-release inbound.

Re: [PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Mon Jan 26, 2015 2:03 am
by Flake
Now Updated to Version 20150126(00)

Changes:
+Fixed a bug in ground objects placement on the Z axis for child scenery objects.
+Fixed a bug in the console where join and leave notifications would be repeated twice.
+Updated the Bug Report form because Pastebin can't handle the amount of data pasted.
-Removed Nukes.

Notes:
~Thank you to Patrick for submitting the bug report that solved this problem.
~The server should now be fully useful for Civillian Server owners and Aerobatics Server Owners.

Download: https://www.mediafire.com/?vcv4grbpyxy6o9v

---

Coming soon:
-Read all flight data. (about 75% of the way there! Really! I could smash it out in 3-4 hours if I wanted to!)
-More commands maybe?
-User Private Messaging - why the hell not...



[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Mon Jan 26, 2015 4:48 am
by Neocon
The ground objects in question are still appearing in the wrong place on my end. Did you double check that you uploaded the new version? I'll debug again tomorrow if I need to do so.

[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Mon Jan 26, 2015 6:18 am
by Flake
Oh Shizzle, I forgot to update the exe in the root folder. If you look in the source release folder that's the updated version there...

But I tested the build and they should be appearing in the right place, even if they are at a funny angle?

Can you send me a flight record of the server grounds in question? Mine are appearing in the right location...

I was looking at the grounds near Bradshaw, namely the stairs and tank etc.

Is there another location that has issues?

[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Mon Jan 26, 2015 11:18 pm
by Neocon
I switched out the OYS application with the one in the release folder. Now the stairs, tanks, and ILS are offset in the opposite directions. I've got to leave for work, so it will be this evening before I can get back to you.

This link has the debug log and saved flights from offline and online from the same plane at the same start position. Let me know if you need more.

[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Tue Jan 27, 2015 1:56 am
by Flake
Looked at the log and I just don't understand why that\s happening.

I've re-organised the child scenery sorting because there was a race condition, and also I fixed a bug where the last ground object of a child scenery would be ommitted.

Also I made OpenYS re-use the old socket in the latest version but that causes a bug where the program won't detect other programs using the same socket - you haven't got another copy (older) running on your machine do you?

My guess is that the grounds were being affected by that race condition which isn't as prevailant on my PC.

I've sorted that out but I honestly just don't see why this is happening for you...

Try this exe, see if you have any luck: https://www.mediafire.com/?osajddsp2irxfat

[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Tue Jan 27, 2015 2:40 am
by Neocon
Ok. Here is the log from that one.
SystemLog.zip
(1.8 MiB) Downloaded 45 times
By the way, is OYS supposed to be able to run normally in debug mode? I ask because it always crashes when I try to log in with YSF.

[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Tue Jan 27, 2015 3:48 am
by Flake
Image

Sigh.

As for the debug crash, not sure... will look into.

[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Tue Jan 27, 2015 6:59 am
by Flake
IGNORE ALL THIS.

I'm at work myself right now and I'm tossing out a few ideas...

Debug program crashes - try logging in with the username "DEBUG" and see what happens. I think it may be a long username crash.
Debug program crashes - are you using the latest test version or stable version of YSF?
Grounds all flippy-whippy. - EDIT: DISREGARD:-> Pat can you upload the version of Antigua_Plus you are using, Map, LST, all of it? I'm using the version as per your websites individual download link for that pack. I don't think you are using a YFS file in the LST for the grounds for that map but if you are on your end that would explain a lot as it means I'm trying to solve the problem by looking in the wrong place. (FLD file loading is different to YFS file loading.)

Earlier I looked at the grounds and they were offset by 1086.33meters on the z axis, 0 m on the x axis. The thing is the 1086 meters measurement doesn't exist anywhere else in the fld file so it must be an error in calculation. I figured the race condition was causing it but I won't know until I find out for sure. EDIT: This does not appear to be the case anymore based off your latest log.

When you crash the debug - when does it crash? as soon as you join the server (I'll assume this.) or when you try and take-off? Does it happen immediately or after a few seconds? (I'll assume after a few seconds when you finish receiving the aircraft lists and the server tries to create entities) Does the console throw an error message prior to locking up? If you look at the crash reason what error message/code do you get (The one that comes with windows assuming you aren't using XP?)

[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Tue Jan 27, 2015 7:21 am
by Flake
Pat I've manually looked at the logs and output of your Offline YFS file and both appear to match:

Image

So the only other explanation is that the server is trying to reposition the root secenery. I'll add a safeguard for that but if you can get that debug to work it should be okay? - We'll see if this is still happening...

Can you try using a shorter username (say "DEBUG" for example) and that debug build I just gave before as I think the long username may be crashing the build? - Tested, it's not. It was the entity placement.

It is entirely possible that my debug aircraft is crashing your build Yes.- try installing my black dragons pack or making a dummy aircraft in your YSF install with the name "F/A-18A_Black_Dragon_#1[Flake]" Don't bother.- I'm guessing the server is trying to load details like it's strength No., etc. and that is crashing the server because it doesn't exist On the right track.. It makes sense... If you don't do this before I get home don't worry, I'll change the debug aircraft back to stock AND remove it entirely unless you join with the "DEBUG" username. Adios amigo, thank you very much for your patience and your help in testing this!

EDIT: Got an idea: My debug plane tries to spawn on a start position starting with RW Eureka.- your map doesn't have any - CRASH! Too right. Please just rename a start position to start with RW (temporarily!) Don't bother, new version below. and the debug should work! ;) I'll make it spawn off start position 0 in the list Just 0,3000,0,0,0,0 now. in future with a safeguard! my bad! I would've picked up on this had I ran the debug build with your map at home rather than constantly building and testing in release mode! Funnily enough it was exactly this. This is knowing your code inside and out huh?

Re: [PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Tue Jan 27, 2015 12:23 pm
by Flake
Now Updated to Version 20150127(2313)

Changes:
+Fixed a bug in debug build that would crash servers without starts with specific phrasing in the name.
+Added automatic version number updater and version number identification to the program. It should now be much easier to see which version of the program you are running.
~Debug Aircraft is now F-22_RAPTOR.
~Debug aircraft now always spawns at 3000m high at 0,0 facing 0,0,0.
-Debug aircraft only spawns when using the username DEBUG in debug build.
-Removed Nukes.

Notes:
~Thank you to Patrick for submitting bug reports solving these problems. I hope to have everything working properly soon/now!
~tested Antigua_Plus with YSF 2013 and 2014 test with short and long usernames and limited aircraft and ground packs, all works ok.
~The server should now be fully useful for Civillian Server owners and Aerobatics Server Owners.

Download: https://www.mediafire.com/?7nlj6b9hlbikdod

---

Coming soon:
More than likely more work on the ground objects placement until it is correct! *pulling my hair out!*
-Read all flight data. (about 75% of the way there! Really! I could smash it out in 3-4 hours if I wanted to!)
-More commands maybe?
-User Private Messaging - why the hell not...



[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Tue Jan 27, 2015 2:37 pm
by Neocon
This version crashes before it can even get started. Windows starts looking for a solution. I just got called to work, so I'll check into it further tonight.

[PROGRAM] OpenYS - Open Source YSFlight Server!

Posted: Tue Jan 27, 2015 7:43 pm
by Flake
Image

Okay thank you. There is absolutely no reason why it should be crashing like this so I'm stumped and I don't know if there is anything I can do. What OS are you running and is it x86 or x64?